Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

feat(Grunt): Add source maps #2858

Closed
wants to merge 1 commit into from
Closed

feat(Grunt): Add source maps #2858

wants to merge 1 commit into from

Conversation

ryanseddon
Copy link

Generate source map files when build step is ran:

  • Handles IE conditional compilation comment issues
  • Prevents caching issues by prefixing full version to map name
  • Upgraded closure compiler to handle v3 maps

@ryanseddon
feat(Grunt): Add source maps
c73865a 
Generate source map files when build step is ran:
- Handles IE conditional compilation comment issues
- Prevents caching issues by prefixing full version to map name
- Upgraded closure compiler to handle v3 maps
@IgorMinar
Copy link
Contributor

why do we need the version number in the file name? is there some source map specific caching issue that I'm not aware of?

I checked out your PR and dropped your closure compiler upgrade (we already upgraded master independently of this).

so the only thing that remains is the filename. I'd rather keep things consistent unless there is a good reason for the current diversion from current naming conventions.

@IgorMinar
Copy link
Contributor

also please sign CLA

@IgorMinar
Copy link
Contributor

PR Checklist (Minor Feature)

  • Contributor signed CLA now or in the past (if you just signed, leave a comment here with your real name for cross reference)
  • Feature improves existing core functionality
  • API is compatible with existing Angular apis and relevant standards (if applicable)
  • PR doesn't contain a breaking change
  • [-] PR contains unit tests
  • [-] PR contains e2e tests (if suitable)
  • [-] PR contains documentation update
  • PR passes all tests on Travis (sanity)
  • PR passes all tests on ci.angularjs.org (cross-browser compatibility)
  • [-] PR is rebased against recent master
  • [-] PR is squashed into one commit per logical change
  • PR's commit messages are descriptive and allows us to autogenerate release notes (required commit message format)
  • All changes requested in review have been implemented

@IgorMinar
Copy link
Contributor

I see that you signed the CLA. please comment on the caching issue and we can merge this in

@IgorMinar IgorMinar mentioned this pull request Jun 8, 2013
Merged
@IgorMinar
Copy link
Contributor

there are several issues with this PR. I think I fixed all of them in #2907 can you please review it?

but even with this, I'm sad to report that debugging won't be must easier, see: https://plus.google.com/u/0/104744871076396904202/posts/8B2aMVH4SHY

I'm going to close this PR. thanks!

@IgorMinar IgorMinar closed this Jun 8, 2013
IgorMinar added a commit to IgorMinar/angular.js that referenced this pull request Jun 15, 2013
@IgorMinar
feat(Grunt): add source maps to all min files
908071a 
Generate source map files when build step is ran and adds source map
headers to all min files.

Source map url must be appended to the min file otherwise the line
offsets will be off.

Inspired by Ryan Seddon (PR angular#2858)

Closes angular#1714
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanseddon @IgorMinar